Skip to content

Update qr-code-scanner extension#26336

Merged
raycastbot merged 3 commits intoraycast:mainfrom
MoienTajik:ext/qr-code-scanner
Mar 30, 2026
Merged

Update qr-code-scanner extension#26336
raycastbot merged 3 commits intoraycast:mainfrom
MoienTajik:ext/qr-code-scanner

Conversation

@MoienTajik
Copy link
Copy Markdown
Contributor

@MoienTajik MoienTajik commented Mar 14, 2026

Description

Fixed URL opening behavior in the QR Code Scanner extension. Previously, when a QR code contained a URL, the extension used the npm open package which bypassed macOS's native URL dispatch system, causing all URLs to open in the browser regardless of registered app handlers (deep-links).

Changes:

  • Replaced the npm open package with Raycast's built-in open from @raycast/api, which correctly delegates to macOS's native open command and respects universal links and custom URL scheme registrations
  • Removed the "Open in Browser?" confirmation dialog — URLs now open immediately in the correct app without an extra prompt
  • Removed the unused open npm dependency from package.json
  • Added npm run publish script to package.json

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: qr-code-scanner Issues related to the qr-code-scanner extension labels Mar 14, 2026
@raycastbot
Copy link
Copy Markdown
Collaborator

raycastbot commented Mar 14, 2026

Thank you for your contribution! 🎉

🔔 @StevenRCE0 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands
BRANCH="ext/qr-code-scanner"
FORK_URL="https://github.com/MoienTajik/raycast-extensions.git"
EXTENSION_NAME="qr-code-scanner"
REPO_NAME="raycast-extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 10-15 business days.

@MoienTajik MoienTajik marked this pull request as ready for review March 14, 2026 22:38
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 14, 2026

Greptile Summary

This PR replaces the npm open package with Raycast's built-in open from @raycast/api for URL handling in the QR Code Scanner extension, and removes the intermediate confirmation dialog so URLs open immediately in the correct app.

  • Switched from import open from "open" to using open from @raycast/api, which properly delegates to macOS's native URL dispatch and respects deep links and custom URL scheme registrations
  • Removed the confirmAlert dialog that previously asked "Open in Browser?" before opening URLs, simplifying the user flow
  • Removed the open npm package from dependencies
  • Added a standard .gitignore and contributor entry
  • Changelog properly updated with {PR_MERGE_DATE} placeholder

Confidence Score: 5/5

  • This PR is safe to merge — it's a clean, focused improvement that uses the recommended Raycast API.
  • The changes are minimal, well-scoped, and follow Raycast best practices. The npm open package is correctly removed and replaced with the built-in Raycast open API. No new logic is introduced — just a simplification of existing behavior. The changelog is properly formatted.
  • No files require special attention.

Important Files Changed

Filename Overview
extensions/qr-code-scanner/src/index.tsx Replaced npm open package with Raycast's built-in open from @raycast/api, and removed the confirmAlert dialog for URL opening. Clean, straightforward change.
extensions/qr-code-scanner/package.json Removed open dependency, added contributor, and added fix-lint and publish scripts.
extensions/qr-code-scanner/CHANGELOG.md Added new changelog entry with {PR_MERGE_DATE} placeholder correctly describing the fix.

Last reviewed commit: 25319ca

@raycastbot
Copy link
Copy Markdown
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Mar 28, 2026
@0xdhrv 0xdhrv self-assigned this Mar 30, 2026
@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Mar 30, 2026
- Introduced a new preference to automatically open decoded URLs after scanning.
- Updated dependencies for improved functionality and security.
- Refactored QR code decoding to use async/await for better error handling.
- Added ESLint configuration for consistent code quality.
Copy link
Copy Markdown
Contributor

@0xdhrv 0xdhrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved ✅

@raycastbot raycastbot merged commit 2ddb6b9 into raycast:main Mar 30, 2026
2 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Published to the Raycast Store:
https://raycast.com/StevenRCE0/qr-code-scanner

@raycastbot
Copy link
Copy Markdown
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: qr-code-scanner Issues related to the qr-code-scanner extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants